[ty] Add "qualify ..." code fix for undefined references#21968
Merged
Conversation
AlexWaygood
added
server
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
Gankra
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
MichaReiser
reviewed
Dec 15, 2025
crates/ty_ide/src/code_action.rs
Outdated
Comment on lines
498
to
501
Member
There was a problem hiding this comment.
This fix here looks off. Any chance we're not using dedent on the source?
Comment on lines
+606
to
+617
| // Request qualifications we could apply to the symbol to make it resolve | ||
| let mut completions = Completions::exactly(db, symbol); | ||
| add_unimported_completions( | ||
| db, | ||
| file, | ||
| parsed, | ||
| scoped, | ||
| |module_name: &ModuleName, symbol: &str| { | ||
| ImportRequest::import(module_name.as_str(), symbol).force() | ||
| }, | ||
| &mut completions, | ||
| ); |
Member
There was a problem hiding this comment.
Do we apply any upper bound on how many actions we show? I'm a bit worried that we now show twice as many code actions in non-trivial cases (e.g. multiple modules exporting the same module), and this can quickly become very noisy for users.
Contributor
Author
There was a problem hiding this comment.
In practice the "qualify..." options will be much rarer because the implementation refuses to show them if it would require editing your imports. As future work we could look into implementing rust-analyzer's more complex UX where you only ever get "import X" and "qualify X" and then e.g. when you select "import" if there was actually multiple possible imports it brings up a secondary menu to select which one you meant.
MichaReiser
approved these changes
Dec 15, 2025
dcreager
added a commit
that referenced
this pull request
Dec 15, 2025
* origin/main: Fluent formatting of method chains (#21369) [ty] Avoid stack overflow when calculating inferable typevars (#21971) [ty] Add "qualify ..." code fix for undefined references (#21968) [ty] Use jemalloc on linux (#21975) Update MSRV to 1.90 (#21987) [ty] Improve check enforcing that an overloaded function must have an implementation (#21978) Update actions/checkout digest to 8e8c483 (#21982) [ty] Use `ParamSpec` without the attr for inferable check (#21934) [ty] Emit diagnostic when a type variable with a default is followed by one without a default (#21787)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
import warningsexists in the file, we will suggest an edit ofdeprecated -> warnings.deprecatedas "qualify warnings.deprecated"Test Plan
Should test more cases...