[ty] Add support for __qualname__ and other implicit class attributes#21966
Merged
charliermarsh merged 3 commits intomainfrom Dec 13, 2025
Merged
[ty] Add support for __qualname__ and other implicit class attributes#21966charliermarsh merged 3 commits intomainfrom
__qualname__ and other implicit class attributes#21966charliermarsh merged 3 commits intomainfrom
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
charliermarsh
changed the title
__qualname__ and other implicit class attributes__qualname__ and other implicit class attributes
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
AlexWaygood
reviewed
Dec 13, 2025
charliermarsh
commented
Dec 13, 2025
| // __doc__ is `str` if there's a docstring, `None` if there isn't | ||
| "__doc__" => Place::bound(UnionType::from_elements( | ||
| db, | ||
| [KnownClass::Str.to_instance(db), Type::none(db)], |
Member
Author
There was a problem hiding this comment.
I think we could detect if a docstring exists and narrow this to str or None respectively. Is that worth doing?
Member
There was a problem hiding this comment.
we could do, but I'm not sure it's worth it. I'd vote for keeping it simple for now and adding it if someone asks for it
dcreager
added a commit
that referenced
this pull request
Dec 15, 2025
* origin/main: Update MSRV to 1.90 (#21987) [ty] Improve check enforcing that an overloaded function must have an implementation (#21978) Update actions/checkout digest to 8e8c483 (#21982) [ty] Use `ParamSpec` without the attr for inferable check (#21934) [ty] Emit diagnostic when a type variable with a default is followed by one without a default (#21787) [ty] Fix callout syntax in configuration mkdocs (#1875) (#21961) Update debug_assert which pointed at missing method (#21969) [ty] Add support for `__qualname__` and other implicit class attributes (#21966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#1873