[flake8-pytest-style] Allow match and check keyword arguments without an expected exception type (PT010)#21964
Merged
ntBre merged 3 commits intoastral-sh:mainfrom Dec 18, 2025
Conversation
|
ntBre
reviewed
Dec 17, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Looks great, thank you! I just had one nit about the docs.
I also thought a bit about making this a preview change in case people had previously had noqa comments like:
with pytest.raises(match="some pattern"): # noqa: PT010but I didn't find any examples of that in a GitHub code search, and the ecosystem check is obviously clean, so I think it's okay to land in stable.
crates/ruff_linter/src/rules/flake8_pytest_style/rules/raises.rs
Outdated
Show resolved
Hide resolved
ntBre
changed the title
match and check keyword arguments without exception class (pytest 8.4.0+)flake8-pytest-style] Allow match and check keyword arguments without an expected exception type (PT010)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates PT010(
pytest-raises-without-exception) to recognizematchandcheckkeyword arguments as valid alternatives to specifying an exception class.As of pytest 8.4.0,
pytest.raises()can be called with onlymatchorcheckkeyword arguments without an expected exception.Fixes #18653
Test Plan
match-only,check-only, and both arguments.cargo test -p ruff_linter -- "pytestraiseswithoutexception"passes