Skip to content

[ty] fix missing heap_size on Salsa query#21912

Merged
carljm merged 1 commit intomainfrom
cjm/heapsize
Dec 11, 2025
Merged

[ty] fix missing heap_size on Salsa query#21912
carljm merged 1 commit intomainfrom
cjm/heapsize

Conversation

@carljm
Copy link
Contributor

@carljm carljm commented Dec 11, 2025

No description provided.

@carljm carljm added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Dec 11, 2025
@astral-sh-bot
Copy link

astral-sh-bot bot commented Dec 11, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Dec 11, 2025

mypy_primer results

Changes were detected when running on open source projects 
beartype (https://github.com/beartype/beartype)
- beartype/claw/_package/clawpkgtrie.py:66:29: warning[unsupported-base] Unsupported class base with type `<class 'dict[str, PackagesTrieBlacklist]'> | <class 'dict[str, Divergent]'>`
- beartype/claw/_package/clawpkgtrie.py:247:29: warning[unsupported-base] Unsupported class base with type `<class 'dict[str, PackagesTrieWhitelist]'> | <class 'dict[str, Divergent]'>`
- Found 492 diagnostics
+ Found 490 diagnostics

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
- src/scikit_build_core/_logging.py:153:13: warning[unsupported-base] Unsupported class base with type `<class 'Mapping[str, Style]'> | <class 'Mapping[str, Divergent]'>`
- src/scikit_build_core/build/wheel.py:98:20: error[no-matching-overload] No overload of bound method `__init__` matches arguments
- Found 43 diagnostics
+ Found 41 diagnostics
Memory usage changes were detected when running on open source projects 
sphinx (https://github.com/sphinx-doc/sphinx)
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`

prefect (https://github.com/PrefectHQ/prefect)
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`
- WARN expected `heap_size` to be provided by Salsa query `class_based_items`

@carljm carljm merged commit 2d0681d into main Dec 11, 2025
44 checks passed
@carljm carljm deleted the cjm/heapsize branch December 11, 2025 02:34
dcreager added a commit that referenced this pull request Dec 11, 2025
@dcreager
Merge remote-tracking branch 'origin/main' into dcreager/param-variance
93e71be 
* origin/main: (29 commits)
  Document range suppressions, reorganize suppression docs (#21884)
  Ignore ruff:isort like ruff:noqa in new suppressions (#21922)
  [ty] Handle `Definition`s in `SemanticModel::scope` (#21919)
  [ty] Attach salsa db when running ide tests for easier debugging (#21917)
  [ty] Don't show hover for expressions with no inferred type (#21924)
  [ty] avoid unions of generic aliases of the same class in fixpoint (#21909)
  [ty] Squash false positive logs for failing to find `builtins` as a real module
  [ty] Uniformly use "not supported" in diagnostics (#21916)
  [ty] Reduce size of ty-ide snapshots (#21915)
  [ty] Adjust scope completions to use all reachable symbols
  [ty] Rename `all_members_of_scope` to `all_end_of_scope_members`
  [ty] Remove `all_` prefix from some routines on UseDefMap
  Enable `--document-private-items` for `ruff_python_formatter` (#21903)
  Remove `BackwardsTokenizer` based `parenthesized_range` references in `ruff_linter` (#21836)
  [ty] Revert "Do not infer types for invalid binary expressions in annotations" (#21914)
  Skip over trivia tokens after re-lexing (#21895)
  [ty] Avoid inferring types for invalid binary expressions in string annotations (#21911)
  [ty] Improve overload call resolution tracing (#21913)
  [ty] fix missing heap_size on Salsa query (#21912)
  [ty] Support implicit type of `cls` in signatures (#21771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager is a code owner

Assignees

No one assigned

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carljm @AlexWaygood