[ty] Improve resolution of absolute imports in tests#21817
Merged
BurntSushi merged 7 commits intomainfrom Dec 12, 2025
Merged
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Gankra
commented
Dec 5, 2025
|
Gankra
changed the title
Gankra
changed the title
Contributor
Author
|
Hmm this is tricky with the tests we have written, I need to look into what pytest actually does/supports. |
Contributor
Author
|
Can't believe Carl convinced me randomly including tests with or without |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
unresolved-import |
33 | 7,404 | 57 |
possibly-missing-attribute |
531 | 10 | 39 |
unresolved-reference |
0 | 535 | 0 |
invalid-argument-type |
509 | 4 | 5 |
unresolved-attribute |
283 | 3 | 0 |
unused-ignore-comment |
2 | 168 | 0 |
unknown-argument |
57 | 26 | 0 |
unsupported-operator |
72 | 0 | 0 |
missing-argument |
58 | 0 | 0 |
no-matching-overload |
58 | 0 | 0 |
invalid-assignment |
46 | 5 | 3 |
possibly-unresolved-reference |
0 | 50 | 0 |
invalid-method-override |
42 | 0 | 0 |
invalid-return-type |
5 | 10 | 1 |
non-subscriptable |
13 | 0 | 0 |
not-iterable |
7 | 0 | 4 |
invalid-exception-caught |
6 | 0 | 0 |
invalid-raise |
6 | 0 | 0 |
unsupported-base |
6 | 0 | 0 |
too-many-positional-arguments |
5 | 0 | 0 |
call-non-callable |
4 | 0 | 0 |
deprecated |
4 | 0 | 0 |
inconsistent-mro |
4 | 0 | 0 |
parameter-already-assigned |
3 | 0 | 0 |
conflicting-metaclass |
0 | 2 | 0 |
invalid-parameter-default |
1 | 0 | 0 |
| Total | 1,755 | 8,217 | 109 |
Contributor
Author
|
Notably having multiple desperate search-paths is problematic for resolving relative imports, with our two-phases |
Contributor
Author
|
One kind of hacky solution would be to refuse to consider the dir the file is in a desperate search-path in |
Contributor
Author
|
Tears of joy at how good these docs are omg https://docs.pytest.org/en/stable/explanation/pythonpath.html |
Contributor
Author
The same can be accomplished by reversing the priority of the desperate search-paths: try the farthest ancestor dir first, allowing us to resolve |
Gankra
force-pushed
the
gankra/notest
branch
from
d29194a to
28e9c9a
Compare
Contributor
Author
|
woah oh god those results |
Gankra
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Gankra
changed the title
Member
|
If not already done, we need to make sure that the option defaults and documentation reflect the newest change regarding the default root paths. |
This was referenced Dec 12, 2025
Contributor
|
I think the spack ecosystem results mostly suggest that it ought to have But I guess not doing that makes it a good test case for what happens when ty is used in a project with an unusual layout and no configuration... |
Gankra
added a commit
that referenced
this pull request
Dec 12, 2025
## Summary ./tests is now no longer an implicit root, per #21817
dcreager
added a commit
that referenced
this pull request
Dec 13, 2025
* origin/main: (22 commits) [ty] Allow gradual lower/upper bounds in a constraint set (#21957) [ty] disallow explicit specialization of type variables themselves (#21938) [ty] Improve diagnostics for unsupported binary operations and unsupported augmented assignments (#21947) [ty] update implicit root docs (#21955) [ty] Enable even more goto-definition on inlay hints (#21950) Document known lambda formatting deviations from Black (#21954) [ty] fix hover type on named expression target (#21952) Bump benchmark dependencies (#21951) Keep lambda parameters on one line and parenthesize the body if it expands (#21385) [ty] Improve resolution of absolute imports in tests (#21817) [ty] Support `__all__ += submodule.__all__` [ty] Change frequency of invalid `__all__` debug message [ty] Add `KnownUnion::to_type()` (#21948) [ty] Classify `cls` as class parameter (#21944) [ty] Stabilize rename (#21940) [ty] Ignore `__all__` for document and workspace symbol requests [ty] Attach db to background request handler task (#21941) [ty] Fix outdated version in publish diagnostics after `didChange` (#21943) [ty] avoid fixpoint unioning of types containing current-cycle Divergent (#21910) [ty] improve bad specialization results & error messages (#21840) ...
Gankra
added a commit
to astral-sh/ty
that referenced
this pull request
Dec 13, 2025
As of astral-sh/ruff#21817, ./tests are no longer implicitly included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By teaching desperate resolution to try every possible ancestor that doesn't have an
__init__.py(i)when resolving absolute imports.testsfrom theenvironment.rootdefault ty#1782