[ty] Emit a diagnostic for subclassing with order=True#21704
Draft
charliermarsh wants to merge 2 commits intomainfrom
Draft
[ty] Emit a diagnostic for subclassing with order=True#21704charliermarsh wants to merge 2 commits intomainfrom
order=True#21704charliermarsh wants to merge 2 commits intomainfrom
Conversation
charliermarsh
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
charliermarsh
changed the title
order=Trueorder=True
Typing conformance resultsNo changes detected ✅ |
|
charliermarsh
force-pushed
the
charlie/order
branch
from
bc1c309 to
4e4b08c
Compare
Member
Author
|
I believe those changes on the conformance tests are "correct" in-so-far as those are instances of the case we want to catch here. |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
subclass-of-dataclass-with-order |
5 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 46 | 0 | 0 |
AlexWaygood
reviewed
Dec 1, 2025
crates/ty_python_semantic/resources/mdtest/dataclasses/dataclasses.md
Outdated
Show resolved
Hide resolved
Member
|
@charliermarsh are you still interested in getting this over the line? |
Member
Author
|
Yes sir, sorry, lost track. |
charliermarsh
force-pushed
the
charlie/order
branch
2 times, most recently
from
24d480b to
634765c
Compare
Member
Author
|
I think the Expression diagnostic is correct: |
charliermarsh
force-pushed
the
charlie/order
branch
from
634765c to
521e4b4
Compare
Memory usage reportMemory usage unchanged ✅ |
charliermarsh
force-pushed
the
charlie/order
branch
2 times, most recently
from
ef4cee5 to
151ce7e
Compare
sharkdp
reviewed
Feb 25, 2026
| &class_node.bases()[i], | ||
| base_params, | ||
| ); | ||
| if let Some(class_params) = class.dataclass_params(self.db()) { |
Contributor
There was a problem hiding this comment.
This will only for work standard library dataclasses. I haven't looked closer at this PR, but we should probably make sure that this works for dataclass_transformers as well. See #23366 for a related PR that expands the frozen/non-frozen-inheritance checks here in the same way.
Member
Author
There was a problem hiding this comment.
Thanks, I attempted to fix it...
Contributor
There was a problem hiding this comment.
Thank you. I will get this PR merged once #23366 lands.
charliermarsh
force-pushed
the
charlie/order
branch
from
151ce7e to
a727348
Compare
charliermarsh
force-pushed
the
charlie/order
branch
from
a727348 to
b2b1ccd
Compare
sharkdp
force-pushed
the
charlie/order
branch
from
b2b1ccd to
25b032f
Compare
sharkdp
requested changes
Feb 27, 2026
Contributor
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
I wanted to get this merged today, but I think it's not quite there yet, so I'm moving this back to draft for now. I'll finish this once I get back.
It doesn't seem to be of high priority. No other type checker supports this, and it's not tested in the conformance suite.
Comment on lines
+469
to
+480
| If the child class also has `order=True`, the diagnostic is suppressed because the child overrides | ||
| all comparison methods: | ||
|
|
||
| ```py | ||
| @dataclass(order=True) | ||
| class OrderedParent2: | ||
| x: int | ||
|
|
||
| @dataclass(order=True) | ||
| class OrderedChild2(OrderedParent2): | ||
| y: str | ||
| ``` |
Contributor
There was a problem hiding this comment.
But OrderedChild2(1,2) < OrderedParent2(1) also fails at runtime. I'm not sure I understand why we suppress the diagnostic in this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#1681.