Skip to content

Comments

[ty] Fix override of final method summary#21681

Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom
MatthewMckee4:final-method-override-summary
Nov 28, 2025
Merged

[ty] Fix override of final method summary#21681
MichaReiser merged 1 commit intoastral-sh:mainfrom
MatthewMckee4:final-method-override-summary

Conversation

@MatthewMckee4
Copy link
Contributor

Summary

Think this was just copied over incorrectly in #21646.

@MatthewMckee4 MatthewMckee4 changed the title Fix override of final method summary [ty] Fix override of final method summary Nov 28, 2025
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser added documentation Improvements or additions to documentation ty Multi-file analysis & type inference labels Nov 28, 2025
@MichaReiser MichaReiser enabled auto-merge (squash) November 28, 2025 16:14
@AlexWaygood
Copy link
Member

whooops, thank you!!

@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 28, 2025

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Nov 28, 2025

mypy_primer results

Changes were detected when running on open source projects
beartype (https://github.com/beartype/beartype)
+ beartype/claw/_package/clawpkgtrie.py:66:29: warning[unsupported-base] Unsupported class base with type `<class 'dict[str, PackagesTrieBlacklist]'> | <class 'dict[str, Divergent]'>`
+ beartype/claw/_package/clawpkgtrie.py:247:29: warning[unsupported-base] Unsupported class base with type `<class 'dict[str, PackagesTrieWhitelist]'> | <class 'dict[str, Divergent]'>`
- Found 498 diagnostics
+ Found 500 diagnostics

scikit-build-core (https://github.com/scikit-build/scikit-build-core)
+ src/scikit_build_core/_logging.py:153:13: warning[unsupported-base] Unsupported class base with type `<class 'Mapping[str, Style]'> | <class 'Mapping[str, Divergent]'>`
- Found 42 diagnostics
+ Found 43 diagnostics

No memory usage changes detected ✅

@MichaReiser MichaReiser merged commit b5b4917 into astral-sh:main Nov 28, 2025
42 checks passed
@MatthewMckee4 MatthewMckee4 deleted the final-method-override-summary branch December 27, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants