[ty] Semantic tokens: mark comprehension targets as definitions#21636
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Nov 26, 2025
Merged
[ty] Semantic tokens: mark comprehension targets as definitions#21636MichaReiser merged 1 commit intoastral-sh:mainfrom
MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #21521 I went through all the statements that may introduce names and marked those names as definitions when computing the semantic tokens. However, names can also be introduced by expressions. Some were already covered (lambdas, named expressions), but comprehensions/generators were not. This commit fixes that, and hopefully completes the set of places that can introduce names.
Test Plan
Added a test to check that the targets of list/set/dict comprehensions and generator expressions are marked as definitions.