[ty] Keep colorizing mypy_primer output#21515
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
sharkdp
force-pushed
the
david/mypy_primer-strip-ansi-hyperlinks
branch
from
ab16263 to
c4a47d1
Compare
sharkdp
changed the title
mypy_primer diffs
sharkdp
added
ci
|
hmm, but it looks like the error code has now been stripped as well? 😄 It's now just I don't mind too much if we just disable colour entirely for ty in mypy_primer. I do occasionally find colourised logs useful, but it's probably not worth spending a lot of time on right now :-) |
oh, but I guess they're missing on the |
Oh, I didn't even notice in the screenshot. Well, that's not my fault. We show the unmodified output in the terminal. I guess the GitHub Actions ANSI parser can't handle hyperlinks?
Ok, I guess I'll just change it |
There was a problem hiding this comment.
Oh, I didn't even notice in the screenshot. Well, that's not my fault. We show the unmodified output in the terminal. I guess the GitHub Actions ANSI parser can't handle hyperlinks?
Hmm. Terminals should skip unsupported ansi escaped without stripping the content.
We can also consider using a crate to dedect supported terminals so that our users can keep using color too. Happy to own that.
|
Sorry for breaking mypy primer, I just published #21519 |
sharkdp
force-pushed
the
david/mypy_primer-strip-ansi-hyperlinks
branch
from
c4a47d1 to
8ffa4a8
Compare
sharkdp
changed the title
mypy_primer diffsmypy_primer output
Thanks. No worries. |
* origin/main: [ty] Fix flaky tests on macos (#21524) [ty] Add tests for generic implicit type aliases (#21522) [ty] Semantic tokens: consistently add the `DEFINITION` modifier (#21521) Only render hyperlinks for terminals known to support them (#21519) [ty] Keep colorizing `mypy_primer` output (#21515) [ty] Exit with `2` if there's any IO error (#21508) [`ruff`] Fix false positive for complex conversion specifiers in `logging-eager-conversion` (`RUF065`) (#21464) [ty] tighten up handling of subscripts in type expressions (#21503)
* origin/main: [ty] Fix flaky tests on macos (#21524) [ty] Add tests for generic implicit type aliases (#21522) [ty] Semantic tokens: consistently add the `DEFINITION` modifier (#21521) Only render hyperlinks for terminals known to support them (#21519) [ty] Keep colorizing `mypy_primer` output (#21515) [ty] Exit with `2` if there's any IO error (#21508) [`ruff`] Fix false positive for complex conversion specifiers in `logging-eager-conversion` (`RUF065`) (#21464) [ty] tighten up handling of subscripts in type expressions (#21503)
3 participants
Summary
After an update to
mypy_primer, we now need to set the environment variable ourselves.