[ruff] Avoid false positive on ClassVar reassignment (RUF012)#21478
Merged
ntBre merged 2 commits intoastral-sh:mainfrom Nov 17, 2025
Merged
[ruff] Avoid false positive on ClassVar reassignment (RUF012)#21478ntBre merged 2 commits intoastral-sh:mainfrom
ruff] Avoid false positive on ClassVar reassignment (RUF012)#21478ntBre merged 2 commits intoastral-sh:mainfrom
Conversation
MichaReiser
changed the title
RUF012 handle ClassVar reassignment
|
ntBre
approved these changes
Nov 17, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you!
I was initially picturing an approach where we looked up the assignment target in the enclosing scope to see if it had previously been the target of an annotated assignment, but I don't think that works because this lint rule runs on deferred scopes. So the approach here makes sense to me instead.
I pushed a commit fixing a couple of small nits:
- Avoid converting the
name.idto a String - Combine the new if-let with the existing
AnnAssignmatch arm - Combine the new
class_var_targets.containscheck with the olditer().all()pattern
ntBre
changed the title
RUF012 handle ClassVar reassignmentruff] Avoid false positive on ClassVar reassignment (RUF012)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21389
Avoid RUF012 false positives when reassigning a ClassVar
Test Plan
Added the new reassignment scenario to
crates/ruff_linter/resources/test/fixtures/ruff/RUF012.py.