[ruff] Add capabilities check for clear_diagnostics_for_document#21188
Closed
TaKO8Ki wants to merge 1 commit intoastral-sh:mainfrom
Closed
[ruff] Add capabilities check for clear_diagnostics_for_document#21188TaKO8Ki wants to merge 1 commit intoastral-sh:mainfrom
ruff] Add capabilities check for clear_diagnostics_for_document#21188TaKO8Ki wants to merge 1 commit intoastral-sh:mainfrom
Conversation
TaKO8Ki
commented
Nov 1, 2025
Comment on lines
+46
to
+48
| if session.resolved_client_capabilities().pull_diagnostics { | ||
| return Ok(()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This change only affects DidClose. For Notebook, there is DidCloseNotebook, so it should not affect Notebook.
Contributor
|
MichaReiser
reviewed
Nov 3, 2025
| return Ok(()); | ||
| }; | ||
| clear_diagnostics_for_document(snapshot.query(), client)?; | ||
| clear_diagnostics_for_document(session, snapshot.query(), client)?; |
Member
There was a problem hiding this comment.
I'm not sure this is correct. This is probably a bit surprising but notebook cells are text documents and the LSP sends close document requests for LSP cells.
Would you mind extending your test plan to cover
- Closing a notebook that has diagnostics
- Removing a cell that contains diagnostics
Member
|
Thank you for working on this. I'll close this PR due to inactivity. Feel free to resubmit this PR with the changes addressed, and we'll happily take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20784 cc: @MichaReiser
This is a follow up to #21105.
#21105 affected Notebook, so in this pull request I just fixed
clear_diagnostics_for_documentthat is not related to Notebook.Test Plan