Skip to content

[ty] Fix playground crash when file name includes path separator #21151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharkdp merged 2 commits into from
Nov 4, 2025
Merged

[ty] Fix playground crash when file name includes path separator #21151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75f43a
[ty] Fix playground crash when file name includes path separator
sharkdp Nov 4, 2025
57fc90a
Use custom HOME directory
sharkdp Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions playground/ty/src/Editor/SecondaryPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,17 @@ function Content({
}
}

const SANDBOX_BASE_DIRECTORY = "/playground/";

function Run({ files, theme }: { files: ReadonlyFiles; theme: Theme }) {
const [runOutput, setRunOutput] = useState<Promise<string> | null>(null);
const handleRun = () => {
const output = (async () => {
const pyodide = await loadPyodide();
const pyodide = await loadPyodide({
env: {
HOME: SANDBOX_BASE_DIRECTORY,
},
});

let combined_output = "";

Expand All @@ -122,7 +128,17 @@ function Run({ files, theme }: { files: ReadonlyFiles; theme: Theme }) {

let fileName = "main.py";
for (const file of files.index) {
pyodide.FS.writeFile(file.name, files.contents[file.id]);
const last_separator = file.name.lastIndexOf("/");

if (last_separator !== -1) {
const directory =
SANDBOX_BASE_DIRECTORY + file.name.slice(0, last_separator);
pyodide.FS.mkdirTree(directory);
}
pyodide.FS.writeFile(
SANDBOX_BASE_DIRECTORY + file.name,
files.contents[file.id],
);

if (file.id === files.selected) {
fileName = file.name;
Expand All @@ -133,7 +149,7 @@ function Run({ files, theme }: { files: ReadonlyFiles; theme: Theme }) {
const globals = dict();

try {
// Patch up reveal types
// Patch `reveal_type` to print runtime values
pyodide.runPython(`
import builtins

Expand Down
Loading