Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions crates/ty_ide/src/goto_definition.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1592,6 +1592,23 @@ a = Test()
");
}

/// Regression test for <https://github.com/astral-sh/ty/issues/1451>.
/// We must ensure we respect re-import convention for stub files for
/// imports in builtins.pyi.
#[test]
fn goto_definition_unimported_symbol_imported_in_builtins() {
let test = CursorTest::builder()
.source(
"main.py",
"
Traceb<CURSOR>ackType
",
)
.build();

assert_snapshot!(test.goto_definition(), @"No goto target found");
}

impl CursorTest {
fn goto_definition(&self) -> String {
let Some(targets) = goto_definition(&self.db, self.cursor.file, self.cursor.offset)
Expand Down
1 change: 1 addition & 0 deletions crates/ty_python_semantic/src/types/ide_support.rs
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ pub fn definitions_for_name<'db>(
};
find_symbol_in_scope(db, builtins_scope, name_str)
.into_iter()
.filter(|def| def.is_reexported(db))
.flat_map(|def| {
resolve_definition(
db,
Expand Down
Loading