[ruff] Use DiagnosticTag for more pyflakes and panda rules
#20801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
MichaReiser
reviewed
Oct 12, 2025
| // PD007 | ||
| "ix" if checker.is_rule_enabled(Rule::PandasUseOfDotIx) => { | ||
| checker.report_diagnostic(PandasUseOfDotIx, range) | ||
| let mut diagnostic = checker.report_diagnostic(PandasUseOfDotIx, range); |
Member
There was a problem hiding this comment.
Hmm. I'm not sure about using deprecated here. The method isn't deprecated according to pandas documentation; they only advise against it. To me, that makes this rule similar to other rules that recommend one pattern over another because it's less error prone
Contributor
Author
There was a problem hiding this comment.
This PandasUseOfDotIx rule is other one PD007 https://docs.astral.sh/ruff/rules/pandas-use-of-dot-ix. It says:
The .ix method is deprecated as its behavior is ambiguous.
So it seems that the method is deprecated?
MichaReiser
reviewed
Oct 12, 2025
MichaReiser
reviewed
Oct 12, 2025
crates/ruff_linter/src/rules/pyflakes/rules/unused_annotation.rs
Outdated
Show resolved
Hide resolved
remove some tags
TaKO8Ki
force-pushed
the
add-DiagnosticTag-to-pyflakes-rules
branch
from
207d914 to
cb59ef8
Compare
Contributor
Author
|
@MichaReiser Thank you for the review. I have addressed your comments. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a part of #20590 and follow up to #20734
Rolling out DiagnosticTag to every existing rule in one go would complicate the review, so in this pull request I’ve limited the changes to flake8 and numpy. (RUF100, PD011, F811, F842, RUF029)
Test Plan