Skip to content

[ty] Fix playground crashes when accessing vendored files with leading slashes #20661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaReiser merged 8 commits into from
Oct 4, 2025
Merged

[ty] Fix playground crashes when accessing vendored files with leading slashes #20661

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9917a54
fix-astral-sh/ty/issues/1290
danparizher Oct 1, 2025
1f1c597
cargo fmt
danparizher Oct 1, 2025
e3aa964
Ignore Windows path prefixes in vendored path normalization
danparizher Oct 1, 2025
ad28975
handle `Utf8Component::Prefix(_)` unconditionally
danparizher Oct 1, 2025
17e551a
Normalize vendored path to remove leading slash
danparizher Oct 2, 2025
a857033
revert changes, add vendored check alongside `/` case
danparizher Oct 3, 2025
e3dfc56
Merge branch 'main' into fix-astral-sh/ty/issues/1290
danparizher Oct 3, 2025
4f987b6
remove erroneous logic from `handleFileAdded`. Only apply to `handFil…
danparizher Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions playground/ty/src/Playground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ export default function Playground() {
setError("File names cannot start with '/'.");
return;
}
if (newName.startsWith("vendored:")) {
setError("File names cannot start with 'vendored:'.");
return;
}

const handle = files.handles[file];
let newHandle: FileHandle | null = null;
Expand Down
Loading