[ty] Fix subtyping of invariant generics specialized with Any#20650
Merged
AlexWaygood merged 2 commits intomainfrom Oct 1, 2025
Merged
[ty] Fix subtyping of invariant generics specialized with Any#20650AlexWaygood merged 2 commits intomainfrom
Any#20650AlexWaygood merged 2 commits intomainfrom
Conversation
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
CodSpeed WallTime Performance ReportMerging #20650 will improve performances by 68.52%Comparing Summary
Benchmarks breakdown
|
This was referenced Sep 30, 2025
dcreager
approved these changes
Sep 30, 2025
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we consider
list[Any]a subtype oflist[Any]. But we shouldn't, for the same reason that we shouldn't considerAnya subtype ofAny: the twoAnys might materialize to different types.The reason why we make this mistake on
mainis that we (correctly) considerlist[Any]to be equivalent tolist[Any], but then incorrectly assume that ifTis equivalent toSthenTwill necessarily be a subtype ofS.Test Plan
main.QUICKCHECK_TESTS=1000000 cargo test --release -p ty_python_semantic -- --ignored types::property_tests::stable