[isort] Clarify dependency between order-by-type and case-sensitive settings#20559
Merged
[isort] Clarify dependency between order-by-type and case-sensitive settings#20559
isort] Clarify dependency between order-by-type and case-sensitive settings#20559Conversation
…ive` settings Summary -- Fixes #20536 by linking between the isort options `case-sensitive` and `order-by-type`. The latter takes precedence over the former, so it seems good to clarify this somewhere. Test Plan -- N/a Co-authored-by: Skyler Wittman <skyler.wittman@gmail.com>
Contributor
|
MichaReiser
approved these changes
Sep 25, 2025
Co-authored-by: Micha Reiser <micha@reiser.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20536 by linking between the isort options
case-sensitiveandorder-by-type. The latter takes precedence over the former, so it seems good to clarify this somewhere.I tweaked the wording slightly, but this is otherwise based on the patch from @SkylerWittman in #20536 (comment) (thank you!)
Test Plan
N/a