[ruff] Fix B004 to skip invalid hasattr/getattr calls#20486
Merged
dylwil3 merged 2 commits intoastral-sh:mainfrom Sep 19, 2025
Merged
[ruff] Fix B004 to skip invalid hasattr/getattr calls#20486dylwil3 merged 2 commits intoastral-sh:mainfrom
ruff] Fix B004 to skip invalid hasattr/getattr calls#20486dylwil3 merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
dylwil3
requested changes
Sep 19, 2025
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
One nit and otherwise looks good, thank you!
crates/ruff_linter/src/rules/flake8_bugbear/rules/unreliable_callable_check.rs
Show resolved
Hide resolved
dylwil3
approved these changes
Sep 19, 2025
ruff] Fix B004 to skip invalid hasattr/getattr callsruff] Fix B004 to skip invalid hasattr/getattr calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20440
Fix B004 to skip invalid hasattr/getattr calls
hasattrandgetattrTest Plan
Add comprehensive test cases for invalid argument patterns including unpacking to
B004.py