[pep8-naming] Fix formatting of __all__ (N816)#20301
Merged
ntBre merged 2 commits intoastral-sh:mainfrom Sep 8, 2025
Merged
Conversation
ntBre
approved these changes
Sep 8, 2025
crates/ruff_linter/src/rules/pep8_naming/rules/mixed_case_variable_in_global_scope.rs
Show resolved
Hide resolved
Contributor
|
ntBre
changed the title
pep8-naming] Fix formatting of __all__ (N816)
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
<!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary Noticed this was not escaped when writing a project that parses the result of `ruff rule --outputformat json`. This is visible here: <https://docs.astral.sh/ruff/rules/mixed-case-variable-in-global-scope/#why-is-this-bad> ## Test Plan documentation only --------- Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed this was not escaped when writing a project that parses the result of
ruff rule --outputformat json. This is visible here: https://docs.astral.sh/ruff/rules/mixed-case-variable-in-global-scope/#why-is-this-badTest Plan
documentation only