Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/ty_python_semantic/resources/mdtest/protocols.md
Original file line number Diff line number Diff line change
Expand Up @@ -2339,6 +2339,28 @@ class Bar(Protocol[S]):
z: S | Bar[S]
```

### Recursive legacy generic protocol

```py
from typing import Generic, TypeVar, Protocol

T = TypeVar("T")

class P(Protocol[T]):
attr: "P[T] | T"

class A(Generic[T]):
attr: T

class B(A[P[int]]):
pass

def f(b: B):
reveal_type(b) # revealed: B
reveal_type(b.attr) # revealed: P[int]
reveal_type(b.attr.attr) # revealed: P[int] | int
```

### Recursive generic protocols with property members

An early version of <https://github.com/astral-sh/ruff/pull/19936> caused stack overflows on this
Expand Down
20 changes: 19 additions & 1 deletion crates/ty_python_semantic/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5959,7 +5959,7 @@ impl<'db> Type<'db> {
/// Note that this does not specialize generic classes, functions, or type aliases! That is a
/// different operation that is performed explicitly (via a subscript operation), or implicitly
/// via a call to the generic object.
#[salsa::tracked(heap_size=ruff_memory_usage::heap_size)]
#[salsa::tracked(heap_size=ruff_memory_usage::heap_size, cycle_fn=apply_specialization_cycle_recover, cycle_initial=apply_specialization_cycle_initial)]
pub(crate) fn apply_specialization(
self,
db: &'db dyn Db,
Expand Down Expand Up @@ -6576,6 +6576,24 @@ impl<'db> VarianceInferable<'db> for Type<'db> {
}
}

fn apply_specialization_cycle_recover<'db>(
_db: &'db dyn Db,
_value: &Type<'db>,
_count: u32,
_self: Type<'db>,
_specialization: Specialization<'db>,
) -> salsa::CycleRecoveryAction<Type<'db>> {
salsa::CycleRecoveryAction::Iterate
}

fn apply_specialization_cycle_initial<'db>(
_db: &'db dyn Db,
_self: Type<'db>,
_specialization: Specialization<'db>,
) -> Type<'db> {
Type::Never
}

/// A mapping that can be applied to a type, producing another type. This is applied inductively to
/// the components of complex types.
///
Expand Down
Loading