Skip to content

[ty] support PEP 613 type aliases #20107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carljm wants to merge 2 commits into from
Closed

[ty] support PEP 613 type aliases #20107

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
546c7e4
[ty] support PEP 613 typing.TypeAlias
carljm Aug 23, 2025
79a1305
fix assertion about the size of `Type`
AlexWaygood Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ty_python_semantic/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11785,7 +11785,7 @@ pub(super) fn determine_upper_bound<'db>(
// Make sure that the `Type` enum does not grow unexpectedly.
#[cfg(not(debug_assertions))]
#[cfg(target_pointer_width = "64")]
static_assertions::assert_eq_size!(Type, [u8; 16]);
static_assertions::assert_eq_size!(Type, [u8; 24]);
Comment on lines 11785 to +11788
Copy link
Member

@AlexWaygood AlexWaygood Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the old assertion no longer passes after rebasing this PR on main. (It seemed to pass on earlier versions of this PR, IIRC.) This PR adds new Type variants, but the wrapped data is all Salsa-interned, and (from local experimentation -- I tried adding some more static_assertions::assert_eq_size!() calls on various wrapped structs and ran cargo check -p ty_python_semantic --release) doesn't appear particularly large

Copy link
Member

@MichaReiser MichaReiser Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what changed but I remember that @ibraheemdev ran into this as well.

it seems that SubclassOfType is 16 bytes and so is KnownInstanceType. But KnownInstanceType was 12 bytes before.


#[cfg(test)]
pub(crate) mod tests {
Expand Down
Loading