Merged
Conversation
AlexWaygood
commented
Aug 26, 2025
Comment on lines
-1454
to
+1461
| # TODO: should pass | ||
| static_assert(not is_subtype_of(XSub, HasXProperty)) # error: [static-assert-error] | ||
| static_assert(not is_assignable_to(XSub, HasXProperty)) # error: [static-assert-error] | ||
| static_assert(not is_subtype_of(XSub, XReadWriteProperty)) | ||
| static_assert(not is_assignable_to(XSub, XReadWriteProperty)) |
Member
Author
There was a problem hiding this comment.
this was a bug in the test: we check assignability of XSub to HasXProperty a few lines above. Here we were meant to be asserting assignability of XSub vs XReadWriteProperty, but there was a copy/paste error in the test
carljm
approved these changes
Aug 26, 2025
carljm
added a commit
to leandrobbraga/ruff
that referenced
this pull request
Aug 27, 2025
* main: [`ruff`] Preserve relative whitespace in multi-line expressions (`RUF033`) (astral-sh#19647) [ty] Optimize TDD atom ordering (astral-sh#20098) [`airflow`] Extend `AIR311` and `AIR312` rules (astral-sh#20082) [ty] Preserve qualifiers when accessing attributes on unions/intersections (astral-sh#20114) [ty] Fix the inferred interface of specialized generic protocols (astral-sh#19866) [ty] Infer slightly more precise types for comprehensions (astral-sh#20111) [ty] Add more tests for protocols (astral-sh#20095) [ty] don't eagerly unpack aliases in user-authored unions (astral-sh#20055) [`flake8-use-pathlib`] Update links to the table showing the correspondence between `os` and `pathlib` (astral-sh#20103) [`flake8-use-pathlib`] Make `PTH100` fix unsafe because it can change behavior (astral-sh#20100) [`flake8-use-pathlib`] Delete unused `Rule::OsSymlink` enabled check (astral-sh#20099) [ty] Add search paths info to unresolved import diagnostics (astral-sh#20040) [`flake8-logging-format`] Add auto-fix for f-string logging calls (`G004`) (astral-sh#19303) Add a `ScopeKind` for the `__class__` cell (astral-sh#20048) Fix incorrect D413 links in docstrings convention FAQ (astral-sh#20089) [ty] Refactor inlay hints structure to use separate parts (astral-sh#20052)
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
Co-authored-by: Shunsuke Shibayama <sbym1346@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds more tests for protocols. It's split out from other PRs that provide functional changes to make those PRs easier to review.
Included here are:
Test Plan
this pr is all tests
Co-authored-by: Shunsuke Shibayama sbym1346@gmail.com