[pyupgrade] Enable rule triggering for stub files (UP043)#20027
Merged
dylwil3 merged 4 commits intoastral-sh:mainfrom Sep 9, 2025
Merged
[pyupgrade] Enable rule triggering for stub files (UP043)#20027dylwil3 merged 4 commits intoastral-sh:mainfrom
pyupgrade] Enable rule triggering for stub files (UP043)#20027dylwil3 merged 4 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| UP043 | 265 | 265 | 0 | 0 | 0 |
Collaborator
|
This looks right to me but since there's (necessarily) such a huge diff in the ecosystem it would be great if e.g. @AlexWaygood could confirm it's all good (and shouldn't be in preview)? |
Contributor
Author
|
@AlexWaygood Could you please review PR? |
ntBre
reviewed
Sep 8, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! I just had a couple of nits but otherwise I agree with Dylan. This looks good, but I'd like to get quick confirmation from Alex that it makes sense to apply this rule to stubs. I think that's the case based on his comment here but good to double check.
I also think this should probably be a preview change. It's a straightforward code fix, but expanding the scope of the rule to a new file type seems pretty significant to me.
Contributor
There was a problem hiding this comment.
Thanks for identifying one of the files from the issue! However, I'd probably lean toward a stripped-down example over including a file verbatim from another project since the specifics of the code aren't really that important. We could even just duplicate UP043.py and call it UP043.pyi, I think.
| /// ## What it does | ||
| /// Checks for unnecessary default type arguments for `Generator` and | ||
| /// `AsyncGenerator` on Python 3.13+. | ||
| /// `AsyncGenerator` on Python 3.13+ or stubs. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// `AsyncGenerator` on Python 3.13+ or stubs. | |
| /// `AsyncGenerator` on Python 3.13+ or in stubs. |
IDrokin117
force-pushed
the
feat/ruff-20011
branch
from
3c5b75d to
c190105
Compare
Member
|
Yup, it makes sense for this to always be enabled for stubs regardless of Python version. I agree with Brent that this should probably be gated behind preview initially. The change was requested by a typeshed maintainer, and I'm also a typeshed maintainer, so I wouldn't worry too much about the impact on typeshed (it's not going to take us by surprise! 😄) -- but there are other authors of stubs out there, and it could take them by surprise to have such a big expansion of the rule go directly into a stable rule without a preview-only period first. |
Member
|
(Sorry for the delayed response -- been a bit busy recently with a house move and other things!) |
Contributor
Author
|
@AlexWaygood Thanks! |
dylwil3
approved these changes
Sep 9, 2025
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
…-sh#20027) ## Summary Resolves astral-sh#20011 Implemented alternative triggering condition for rule [`UP043`](https://docs.astral.sh/ruff/rules/unnecessary-default-type-args/) based on requirements outlined in [issue astral-sh#20011](astral-sh#20011) ## Test Plan Created .pyi file to ensure triggering the rule --------- Co-authored-by: Igor Drokin <drokinii1017@gmail.com> Co-authored-by: dylwil3 <dylwil3@gmail.com>
ntBre
added a commit
that referenced
this pull request
Jan 30, 2026
ntBre
added a commit
that referenced
this pull request
Jan 30, 2026
ntBre
added a commit
that referenced
this pull request
Feb 3, 2026
ntBre
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #20011
Implemented alternative triggering condition for rule
UP043based on requirements outlined in issue #20011Test Plan
Created .pyi file to ensure triggering the rule