(fix): properly handle empty comments on next physical line after line continuation#19338
Closed
soundsonacid wants to merge 0 commit intoastral-sh:mainfrom
Closed
(fix): properly handle empty comments on next physical line after line continuation#19338soundsonacid wants to merge 0 commit intoastral-sh:mainfrom
soundsonacid wants to merge 0 commit intoastral-sh:mainfrom
Conversation
Contributor
|
ntBre
added
bug
ntBre
reviewed
Jul 16, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks for working on this! I had a small suggestion and also found a helpful-looking Indexer method that might simplify things a bit.
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19326