[pyupgrade] Remove non-pep604-isinstance (UP038)

changelogs/0.1.x.md

@@ -90,7 +90,6 @@ _New rules are added in [preview](https://docs.astral.sh/ruff/preview/)._
 - Default to following the system dark/light mode ([#7888](https://github.com/astral-sh/ruff/pull/7888))
 - Add documentation for fixes ([#7901](https://github.com/astral-sh/ruff/pull/7901))
 - Fix typo in docs of `PLR6301` ([#7831](https://github.com/astral-sh/ruff/pull/7831))
-- Update `UP038` docs to note that it results in slower code ([#7872](https://github.com/astral-sh/ruff/pull/7872))
 - crlf -> cr-lf ([#7766](https://github.com/astral-sh/ruff/pull/7766))
 - Add an example of an unsafe fix ([#7924](https://github.com/astral-sh/ruff/pull/7924))
 - Fix documented examples for `unnecessary-subscript-reversal` ([#7774](https://github.com/astral-sh/ruff/pull/7774))

changelogs/0.10.x.md

@@ -33,7 +33,6 @@ See also, the "Remapped rules" section which may result in disabled rules.
 
 The following rules have been deprecated:
 
-- [`non-pep604-isinstance`](https://docs.astral.sh/ruff/rules/non-pep604-isinstance/) (`UP038`)
 - [`suspicious-xmle-tree-usage`](https://docs.astral.sh/ruff/rules/suspicious-xmle-tree-usage/) (`S320`)
 
 ### Remapped rules

crates/ruff_linter/src/checkers/ast/analyze/expression.rs

@@ -650,11 +650,6 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
                     pyupgrade::rules::timeout_error_alias_call(checker, func);
                 }
             }
-            if checker.is_rule_enabled(Rule::NonPEP604Isinstance) {
-                if checker.target_version() >= PythonVersion::PY310 {
-                    pyupgrade::rules::use_pep604_isinstance(checker, expr, func, args);
-                }
-            }
             if checker.is_rule_enabled(Rule::BlockingHttpCallInAsyncFunction) {
                 flake8_async::rules::blocking_http_call(checker, call);
             }

crates/ruff_linter/src/codes.rs

@@ -548,7 +548,6 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Pyupgrade, "035") => (RuleGroup::Stable, rules::pyupgrade::rules::DeprecatedImport),
         (Pyupgrade, "036") => (RuleGroup::Stable, rules::pyupgrade::rules::OutdatedVersionBlock),
         (Pyupgrade, "037") => (RuleGroup::Stable, rules::pyupgrade::rules::QuotedAnnotation),
-        (Pyupgrade, "038") => (RuleGroup::Deprecated, rules::pyupgrade::rules::NonPEP604Isinstance),
         (Pyupgrade, "039") => (RuleGroup::Stable, rules::pyupgrade::rules::UnnecessaryClassParentheses),
         (Pyupgrade, "040") => (RuleGroup::Stable, rules::pyupgrade::rules::NonPEP695TypeAlias),
         (Pyupgrade, "041") => (RuleGroup::Stable, rules::pyupgrade::rules::TimeoutErrorAlias),

crates/ruff_linter/src/rules/pyupgrade/mod.rs

@@ -44,7 +44,6 @@ mod tests {
     #[test_case(Rule::NonPEP585Annotation, Path::new("UP006_3.py"))]
     #[test_case(Rule::NonPEP604AnnotationUnion, Path::new("UP007.py"))]
     #[test_case(Rule::NonPEP604AnnotationOptional, Path::new("UP045.py"))]
-    #[test_case(Rule::NonPEP604Isinstance, Path::new("UP038.py"))]
     #[test_case(Rule::OSErrorAlias, Path::new("UP024_0.py"))]
     #[test_case(Rule::OSErrorAlias, Path::new("UP024_1.py"))]
     #[test_case(Rule::OSErrorAlias, Path::new("UP024_2.py"))]

crates/ruff_linter/src/rules/pyupgrade/rules/mod.rs

@@ -36,7 +36,6 @@ pub(crate) use unnecessary_future_import::*;
 pub(crate) use unpacked_list_comprehension::*;
 pub(crate) use use_pep585_annotation::*;
 pub(crate) use use_pep604_annotation::*;
-pub(crate) use use_pep604_isinstance::*;
 pub(crate) use useless_class_metaclass_type::*;
 pub(crate) use useless_metaclass_type::*;
 pub(crate) use useless_object_inheritance::*;
@@ -80,7 +79,6 @@ mod unnecessary_future_import;
 mod unpacked_list_comprehension;
 mod use_pep585_annotation;
 mod use_pep604_annotation;
-mod use_pep604_isinstance;
 mod useless_class_metaclass_type;
 mod useless_metaclass_type;
 mod useless_object_inheritance;

python/py-fuzzer/pyproject.toml

@@ -62,9 +62,6 @@ ignore = [
     # These are enforced by, or incompatible with, the ruff formatter:
     "E203",
     "E501",
-    # Makes code slower and more verbose
-    # https://github.com/astral-sh/ruff/issues/7871
-    "UP038",
 ]
 unfixable = [
     "F841",   # unused variable. ruff keeps the call, but mostly it's best to get rid of it all