[flake8-simplify] Make example error out-of-the-box (SIM116)

[MeGaGiGaGon]

Summary

Part of #18972

This PR makes if-else-block-instead-of-dict-lookup (SIM116)'s example error out-of-the-box

Old example

if x == 1:
    return "Hello"
elif x == 2:
    return "Goodbye"
else:
    return "Goodnight"

New example

def find_phrase(x):
    if x == 1:
        return "Hello"
    elif x == 2:
        return "Goodbye"
    elif x == 3:
        return "Good morning"
    else:
        return "Goodnight"

The "Use instead" section was also updated to reflect the new case. I also changed it to use an intermediary variable since I find the return <long dict>.get very ugly and hard to read.

Test Plan

N/A, no functionality/tests affected

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[ntBre]

Should we wrap these in functions? Otherwise the returns should be syntax errors. I was alarmed that we weren't flagging the syntax error, but that semantic error is still associated with the F706 lint rule.

[MeGaGiGaGon]

That would probably be a good idea. I ran my tool again looking for that, and I got only this rule and UP028 as having examples that raised one of F701-F706 (Aside from those rule's examples themselves).

Should the tests also be updated? Since they have the same problem as the example. I also did a ruff run on the tests itself, and found a few other rules that run into these in their tests:

crates\ruff_linter\resources\test\fixtures\flake8_bandit\S112.py: F702 `continue` not properly in loop
crates\ruff_linter\resources\test\fixtures\flake8_bugbear\B031.py: F706 `return` statement outside of a function/method
crates\ruff_linter\resources\test\fixtures\flake8_pie\PIE804.py: F704 `yield` statement outside of a function
crates\ruff_linter\resources\test\fixtures\flake8_simplify\SIM115.py: F704 `await` statement outside of a function
crates\ruff_linter\resources\test\fixtures\flake8_simplify\SIM116.py: F706 `return` statement outside of a function/method
crates\ruff_linter\resources\test\fixtures\pycodestyle\E27.py: F704 `yield` statement outside of a function

[MeGaGiGaGon]

I got a couple more hits adding the "Use instead" sections to the search, SIM110 and PLW1501

[ntBre]

Sure, that seems like a good idea! I think the plan is still to make those rules into true SyntaxErrors eventually, so these snapshots would change then anyway.

[ntBre]

Thanks!