-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] Add micro-benchmark for #711 #18979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CodSpeed Instrumentation Performance ReportMerging #18979 will not alter performanceComparing Summary
Benchmarks breakdown
|
|
Oof... I just ran the benchmarks locally to see if a change I was experimenting with had a performance impact, and this new benchmark takes over a minute to run (much longer than any other ty benchmark): The command I ran locally was Can we make this slightly less diabolical for now, so that it's possible to run benchmarks locally in a reasonable time? |
Oh, sorry! Will fix that later. In the meantime, you can use a filter argument or reduce the amount of samples ( |
* main: [ty] Add builtins to completions derived from scope (#18982) [ty] Don't add incorrect subdiagnostic for unresolved reference (#18487) [ty] Simplify `KnownClass::check_call()` and `KnownFunction::check_call()` (#18981) [ty] Add micro-benchmark for #711 (#18979) [`flake8-annotations`] Make `ANN401` example error out-of-the-box (#18974) [`flake8-async`] Make `ASYNC110` example error out-of-the-box (#18975) [pandas]: Fix issue on `non pandas` dataframe `in-place` usage (PD002) (#18963) [`pylint`] Fix `PLC0415` example (#18970) [ty] Add environment variable to dump Salsa memory usage stats (#18928) [`pylint`] Fix `PLW0108` autofix introducing a syntax error when the lambda's body contains an assignment expression (#18678) Bump 0.12.1 (#18969) [`FastAPI`] Add fix safety section to `FAST002` (#18940) [ty] Add regression test for leading tab mis-alignment in diagnostic rendering (#18965) [ty] Resolve python environment in `Options::to_program_settings` (#18960) [`ruff`] Fix false positives and negatives in `RUF010` (#18690) [ty] Fix rendering of long lines that are indented with tabs [ty] Add regression test for diagnostic rendering panic [ty] Move venv and conda env discovery to `SearchPath::from_settings` (#18938)
|
Re: #18979 (comment) Each check increases the runtime by a factor of 3, so this should be an order of magnitude faster.
Summary
Add a benchmark for the problematic case in astral-sh/ty#711, which will potentially be solved in #18955