[flake8-annotations] Do not automatically set the return type to NoReturn when raising NotImplementedError#18927
Closed
danparizher wants to merge 1 commit intoastral-sh:mainfrom
Closed
[flake8-annotations] Do not automatically set the return type to NoReturn when raising NotImplementedError#18927danparizher wants to merge 1 commit intoastral-sh:mainfrom
flake8-annotations] Do not automatically set the return type to NoReturn when raising NotImplementedError#18927danparizher wants to merge 1 commit intoastral-sh:mainfrom
Conversation
danparizher
changed the title
ANN] automatically sets the return type to NoReturn to raise NotImplementedError
danparizher
changed the title
ANN] automatically sets the return type to NoReturn to raise NotImplementedErrorflake8-annotations] automatically sets the return type to NoReturn to raise NotImplementedError
danparizher
changed the title
flake8-annotations] automatically sets the return type to NoReturn to raise NotImplementedErrorflake8-annotations] Do not automatically set the return type to NoReturn when raising NotImplementedError
Contributor
|
MichaReiser
reviewed
Jun 25, 2025
| } | ||
| } | ||
|
|
||
| fn raises_only_not_implemented_error(function: &ast::StmtFunctionDef) -> bool { |
Member
There was a problem hiding this comment.
It seems unfortunate that we need to traverse the entire function again to determine if all of them were RaiseNotImplemented. Should we add a new Terminal::RaiseNotImplemented variant instead?
Contributor
Author
There was a problem hiding this comment.
Good point—but the extra walk only happens when we’ve already determined the function is Terminal::Raise, so the cost is minimal. Extending Terminal with a RaiseNotImplemented would mix exception-specific semantics into what’s currently a pure control-flow enum and force every existing caller to handle a new case.
Contributor
Author
|
Going to close and redo this PR as it has been stale for a few months |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18886
Test Plan