Skip to content

[ty] Install more dependencies before benchmarking hydra-zen #18757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWaygood wants to merge 1 commit into from
Closed

[ty] Install more dependencies before benchmarking hydra-zen #18757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ruff_benchmark/benches/ty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ fn hydra(criterion: &mut Criterion) {
repository: "https://github.com/mit-ll-responsible-ai/hydra-zen",
commit: "dd2b50a9614c6f8c46c5866f283c8f7e7a960aa8",
paths: vec![SystemPath::new("src")],
dependencies: vec!["pydantic", "beartype", "hydra-core"],
dependencies: vec!["pydantic", "beartype", "hydra-core", "pytest", "hypothesis"],
Copy link
Member

@MichaReiser MichaReiser Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment but you might want to lower the number of the max expected diagnostics on line 441.

That makes me realise that we may want to enable all rules, including possibly-* rules

Copy link
Member Author

@AlexWaygood AlexWaygood Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes me realise that we may want to enable all rules, including possibly-* rules

that makes sense but I'll leave it out of this PR

Copy link
Member

@MichaReiser MichaReiser Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, that was more a note for myself

max_dep_date: "2025-06-17",
python_version: PythonVersion::PY313,
},
Expand Down
Loading