[ruff] Frozen Dataclass default should be valid (RUF009)#18735
Merged
ntBre merged 19 commits intoastral-sh:mainfrom Jun 23, 2025
Merged
[ruff] Frozen Dataclass default should be valid (RUF009)#18735ntBre merged 19 commits intoastral-sh:mainfrom
ruff] Frozen Dataclass default should be valid (RUF009)#18735ntBre merged 19 commits intoastral-sh:mainfrom
Conversation
lubaskinc0de
changed the title
crates/ruff_linter/src/rules/ruff/rules/function_call_in_dataclass_default.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
ready for review |
Contributor
Author
|
i am also fixed dataclass_kind helper more info here https://discord.com/channels/1039017663004942429/1039017663512449056/1385177991319126117 |
MichaReiser
changed the title
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)
reflex-dev/reflex (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
+ reflex/event.py:573:72: RUF100 [*] Unused `noqa` directive (unused: `RUF009`)
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 1 | 1 | 0 | 0 | 0 |
ntBre
changed the title
ruff] Frozen Dataclass default should be valid (RUF009)
ntBre
reviewed
Jun 23, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks, this looks great overall! I just have a few suggestions for simplifying things a bit.
crates/ruff_linter/src/rules/ruff/rules/function_call_in_dataclass_default.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/ruff/rules/function_call_in_dataclass_default.rs
Show resolved
Hide resolved
… into feat/frozen-dc-default
ntBre
approved these changes
Jun 23, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thank you, this is great! Just one more tiny nit, and it looks like clippy also has a minor complaint, but this is otherwise good to go.
crates/ruff_linter/src/rules/ruff/rules/function_call_in_dataclass_default.rs
Outdated
Show resolved
Hide resolved
ntBre
approved these changes
Jun 23, 2025
dcreager
added a commit
that referenced
this pull request
Jun 24, 2025
* main: [ty] Fix false positives when subscripting an object inferred as having an `Intersection` type (#18920) [`flake8-use-pathlib`] Add autofix for `PTH202` (#18763) [ty] Add relative import completion tests [ty] Clarify what "cursor" means [ty] Add a cursor test builder [ty] Enforce sort order of completions (#18917) [formatter] Fix missing blank lines before decorated classes in .pyi files (#18888) Apply fix availability and applicability when adding to `DiagnosticGuard` and remove `NoqaCode::rule` (#18834) py-fuzzer: allow relative executable paths (#18915) [ty] Change `environment.root` to accept multiple paths (#18913) [ty] Rename `src.root` setting to `environment.root` (#18760) Use file path for detecting package root (#18914) Consider virtual path for various server actions (#18910) [ty] Introduce `UnionType::try_from_elements` and `UnionType::try_map` (#18911) [ty] Support narrowing on `isinstance()`/`issubclass()` if the second argument is a dynamic, intersection, union or typevar type (#18900) [ty] Add decorator check for implicit attribute assignments (#18587) [`ruff`] Trigger `RUF037` for empty string and byte strings (#18862) [ty] Avoid duplicate diagnostic in unpacking (#18897) [`pyupgrade`] Extend version detection to include `sys.version_info.major` (`UP036`) (#18633) [`ruff`] Frozen Dataclass default should be valid (`RUF009`) (#18735)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/closes #17424
Test Plan