Drop confusing second * from glob pattern example
#18709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As @AlexWaygood noted on the 0.12 release blog post draft, the existing example is a bit confusing. Either
**/*.pyor just*.py, as I went with here, makes more sense, although the old version (scripts/**.py) also worked when I tested it. However, this probably shouldn't be relied upon since the globset docs say:where "anywhere else" comes after the listing of the three valid positions:
**/)/**)/**/)I think the current version is luckily treated the same as a single
*, and the default globbing settings allow it to match subdirectories such that the new example pattern will apply to the wholescriptstree in a project like this:Test Plan
Local testing of the new pattern, but the specifics of the pattern aren't as important as having a more intuitive-looking/correct example.