Skip to content

unnecessary_dict_kwargs doc - a note on type checking benefits #18666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaReiser merged 1 commit into from
Jun 20, 2025
Merged

unnecessary_dict_kwargs doc - a note on type checking benefits #18666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/ruff_linter/src/rules/flake8_pie/rules/unnecessary_dict_kwargs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ use crate::{Applicability, Edit, Fix, FixAvailability, Violation};
///
/// ## Why is this bad?
/// If the `dict` keys are valid identifiers, they can be passed as keyword
/// arguments directly.
/// arguments directly, without constructing unnecessary dictionary.
/// This also makes code more type-safe as type checkers often cannot
/// precisely verify dynamic keyword arguments.
///
/// ## Example
///
Expand All @@ -26,6 +28,9 @@ use crate::{Applicability, Edit, Fix, FixAvailability, Violation};
///
///
/// print(foo(**{"bar": 2})) # prints 3
///
/// # No typing errors, but results in an exception at runtime.
/// print(foo(**{"bar": 2, "baz": 3}))
/// ```
///
/// Use instead:
Expand All @@ -36,6 +41,9 @@ use crate::{Applicability, Edit, Fix, FixAvailability, Violation};
///
///
/// print(foo(bar=2)) # prints 3
///
/// # Typing error detected: No parameter named "baz".
/// print(foo(bar=2, baz=3))
/// ```
///
/// ## Fix safety
Expand Down
Loading