[refurb] Add a note about float literal handling (FURB157)
#18615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary
--
Updates the rule docs to explicitly state how cases like `Decimal("0.1")` are
handled (not affected) because the discussion of "float casts" referring to
values like `nan` and `inf` are otherwise a bit confusing.
These changes are based on suggestions from @AlexWaygood on Notion, with a
slight adjustment to use 0.1 instead of 0.5 since it causes a more immediate
issue in the REPL:
```pycon
>>> from decimal import Decimal
>>> Decimal(0.5) == Decimal("0.5")
True
>>> Decimal(0.1) == Decimal("0.1")
False
```
Test plan
--
N/a
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Jun 10, 2025
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the rule docs to explicitly state how cases like
Decimal("0.1")are handled (not affected) because the discussion of "float casts" referring to values likenanandinfis otherwise a bit confusing.These changes are based on suggestions from @AlexWaygood on Notion, with a slight adjustment to use 0.1 instead of 0.5 since it causes a more immediate issue in the REPL:
Test plan
N/a