ruff/__main__.py: Remove unnecessary os.fsdecode#18551
Merged
AlexWaygood merged 1 commit intoastral-sh:mainfrom Jun 9, 2025
Merged
ruff/__main__.py: Remove unnecessary os.fsdecode#18551AlexWaygood merged 1 commit intoastral-sh:mainfrom
ruff/__main__.py: Remove unnecessary os.fsdecode#18551AlexWaygood merged 1 commit intoastral-sh:mainfrom
Conversation
find_ruff_bin() returns str, so this is a no-op
AlexWaygood
approved these changes
Jun 9, 2025
AlexWaygood
changed the title
ruff/__main__.py: Remove unnecessary os.fsdecode
Contributor
|
med1844
pushed a commit
to med1844/ruff
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is really minor, but
find_ruff_bin()returnsstr, so callingos.fsdecodeis a no-op. This was missed whenfind_ruff_bin()was refactored to no longer returnPath.Test Plan
N/A