Skip to content

Treat ty: comments as pragma comments #18532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

Treat ty: comments as pragma comments #18532

merged 1 commit into from
Jun 7, 2025

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jun 7, 2025 •
edited
Loading

Summary

Add support for ty's ty: pragma comments to ruff's formatter and E501

Fixes #18529

Test Plan

Added test

@MichaReiser MichaReiser added rule Implementing or modifying a lint rule formatter Related to the formatter labels Jun 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser merged commit b3b900d into main Jun 7, 2025
34 checks passed
@MichaReiser MichaReiser deleted the micha/ty-pragma-comments branch June 7, 2025 14:02
@BrewTestBot BrewTestBot mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

formatter Related to the formatter rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

formatter moves ty:ignore comments

3 participants

@MichaReiser @AlexWaygood