Skip to content

[ruff] skip fix for RUF059 if dummy name is already bound (unused-unpacked-variable) #18509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

[ruff] skip fix for RUF059 if dummy name is already bound (unused-unpacked-variable) #18509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
820791d
[`ruff`] skip fix for `RUF059` if dummy name is already bound (unused…
chirizxc Jun 6, 2025
3ea80eb
refactor: use `ShadowedKind`
chirizxc Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/ruff/RUF059_0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,9 @@ def f():
(exponential := (exponential * base_multiplier) % 3): i + 1 for i in range(2)
}
return hash_map


# see: https://github.com/astral-sh/ruff/issues/18507
def f(_x):
x, = "1"
print(_x)
10 changes: 10 additions & 0 deletions crates/ruff_linter/src/rules/ruff/rules/unused_unpacked_variable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,16 @@ fn remove_unused_variable(binding: &Binding, checker: &Checker) -> Option<Fix> {

let name = binding.name(checker.source());
let renamed = format!("_{name}");

let scope = checker.semantic().scopes.get(binding.scope)?;

if scope
.bindings()
.any(|(_, id)| checker.semantic().binding(id).name(checker.source()) == renamed)
{
return None;
}
Copy link
Member

@MichaReiser MichaReiser Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use the following here (which is what we use in other places to test shadowing)

ruff/crates/ruff_linter/src/rules/pyupgrade/rules/pep695/private_type_parameter.rs

Lines 137 to 139 in 9925910

if ShadowedKind::new(binding, new_name, checker).shadows_any() {
return;
}


if checker.settings.dummy_variable_rgx.is_match(&renamed) {
let edit = Edit::range_replacement(renamed, binding.range());

Expand Down
12 changes: 11 additions & 1 deletion ..._linter/src/rules/ruff/snapshots/ruff_linter__rules__ruff__tests__RUF059_RUF059_0.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,4 +197,14 @@ RUF059_0.py:86:29: RUF059 [*] Unpacked variable `that` is never used
86 |+ open("") as ((this, _that)),
87 87 | ):
88 88 | print("hello")
89 89 |
89 89 |

RUF059_0.py:101:5: RUF059 Unpacked variable `x` is never used
|
99 | # see: https://github.com/astral-sh/ruff/issues/18507
100 | def f(_x):
101 | x, = "1"
| ^ RUF059
102 | print(_x)
|
= help: Prefix it with an underscore or any other dummy variable pattern
Loading