[ty] Fix completion order in playground#18480
Merged
MichaReiser merged 1 commit intomainfrom Jun 5, 2025
Merged
Conversation
MichaReiser
added
playground
MichaReiser
commented
Jun 5, 2025
| this.inlayHintsDisposable.dispose(); | ||
| this.formatDisposable.dispose(); | ||
| this.editorOpenerDisposable.dispose(); | ||
| this.completionDisposable.dispose(); |
Member
Author
There was a problem hiding this comment.
That was a copy paste error of mine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
By default, Monaco sorts the completion items by the label but we want to preserve the order
returned by the
completionsfunctions. Ideally, we could just disable sorting but I couldn't find a way to do this.This PR sets the
sortTextwhich monaco uses for sorting. It's a bit awkward because it's a string (which gets compared in alphabetic ordering)But the basic idea is that we use the padded index as sort key.
Test Plan
Screen.Recording.2025-06-05.at.18.28.01.mov