Skip to content

add full option name in formatter warning #18217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaReiser merged 5 commits into from
May 20, 2025
Merged

add full option name in formatter warning #18217

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3856aa
add full option name in formatter warning
CodeMan62 May 20, 2025
aeb0df7
fix the path
CodeMan62 May 20, 2025
077213b
final refactor
CodeMan62 May 20, 2025
f558548
final changes
CodeMan62 May 20, 2025
c0fd63f
Merge branch 'main' into codeman/18199
CodeMan62 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/ruff/tests/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ if condition:
print('Should change quotes')

----- stderr -----
warning: The following rule may cause conflicts when used with the formatter: `COM812`. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the `select` or `extend-select` configuration, or adding it to the `ignore` configuration.
warning: The following rule may cause conflicts when used with the formatter: `COM812`. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the `select` or `extend-select` configuration, or adding it to the `ruff.ignore` configuration.

@MichaReiser MichaReiser May 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you change here is the test. You need to change the implementation here

ruff/crates/ruff/src/commands/format.rs

Line 824 in fa62801

warn_user_once!("The following rule may cause conflicts when used with the formatter: {rule}. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the `select` or `extend-select` configuration, or adding it to the `ignore` configuration.");
(and other lines)

@CodeMan62 CodeMan62 May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks i was just finding it.
EDIT:- Done

"#);
Ok(())
}
Expand Down Expand Up @@ -899,7 +899,7 @@ if True:
Cause: Failed to parse [RUFF-TOML-PATH]
Cause: TOML parse error at line 1, column 1
|
1 |
1 |
| ^
unknown field `tab-size`
");
Expand Down