[flake8-simplify] enable fix in preview mode (SIM117)#18208
Merged
dylwil3 merged 5 commits intoastral-sh:mainfrom May 20, 2025
Merged
[flake8-simplify] enable fix in preview mode (SIM117)#18208dylwil3 merged 5 commits intoastral-sh:mainfrom
flake8-simplify] enable fix in preview mode (SIM117)#18208dylwil3 merged 5 commits intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SIM117 | 356 | 0 | 0 | 356 | 0 |
dylwil3
requested changes
May 19, 2025
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
Thank you! This is great - could you add a test as well? You should be able to just copy the same test fixture path here:
Co-authored-by: Dylan <[email protected]>
Co-authored-by: Dylan <[email protected]>
Contributor
Author
|
@dylwil3 thanks for the guidance ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR add the
fix safetysection for ruleSIM117(#15584 ), and enable a fix in preview mode.@dylwil3 Is the first time I'm exposed to the preview mode. So please let me know what should I do/fix. I hope I got what you wanted to say.