[ty] fix infinite recursion bug in is_disjoint_from#18043
Merged
AlexWaygood merged 1 commit intoastral-sh:mainfrom May 12, 2025
Merged
[ty] fix infinite recursion bug in is_disjoint_from#18043AlexWaygood merged 1 commit intoastral-sh:mainfrom
is_disjoint_from#18043AlexWaygood merged 1 commit intoastral-sh:mainfrom
Conversation
mtshiba
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
AlexWaygood
added
bug
AlexWaygood
approved these changes
May 12, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Wow, that's subtle. Great catch, thank you!
Contributor
|
Thank you!! |
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
## Summary I found this bug while working on astral-sh#18041. The following code leads to infinite recursion. ```python from ty_extensions import is_disjoint_from, static_assert, TypeOf class C: @Property def prop(self) -> int: return 1 static_assert(not is_disjoint_from(int, TypeOf[C.prop])) ``` The cause is a trivial missing binding in `is_disjoint_from`. This PR fixes the bug and adds a test case (this is a simple fix and may not require a new test case?). ## Test Plan A new test case is added to `mdtest/type_properties/is_disjoint_from.md`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I found this bug while working on #18041. The following code leads to infinite recursion.
The cause is a trivial missing binding in
is_disjoint_from. This PR fixes the bug and adds a test case (this is a simple fix and may not require a new test case?).Test Plan
A new test case is added to
mdtest/type_properties/is_disjoint_from.md.