Conversation
MichaReiser
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
|
@ZeusKC52 could you try if this version works fine for you on android? |
MichaReiser
requested review from
ntBre
and removed request for
AlexWaygood,
carljm,
dcreager and
sharkdp
|
|
How do i run this on termux? |
|
Not sure, I never used termux. YOu can clone this repository and then run The alternative is we land this PR and you wait for the next release to test it out and you report back in case it doesn't work. |
|
How do i clone this pull request? I looked on the internet but nothing seems to work. |
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks, this makes sense to me!
crates/ty/src/main.rs
Outdated
| // Use `writeln` instead of `eprintln` to avoid panicking when the stderr pipe is broken. | ||
| let mut stderr = io::stderr().lock(); | ||
|
|
||
| // |
There was a problem hiding this comment.
This looks like it might be unrelated
You can run git clone -b micha/disable-jemalloc-android https://github.com/astral-sh/ruff --depth 1I also threw in I have a couple of old android devices I can possibly try to charge if needed too. |
|
Let's test this with the next release. |
|
Tried and it gave me this: $ git clone -b micha/disable-jemalloc-android https://github.com/astral-sh/ruff --depth 1 What now? |
|
The branch has now been merged into the cd ruff
git pull
cargo build --bin ruffOr you can wait for the next release later this week! |
* main: disable jemalloc on android (#18033) [ty] Fix incorrect type of `src.root` in documentation (#18040) [ty] Refine message for why a rule is enabled (#18038) [ty] Remove brackets around option names (#18037) Update pre-commit dependencies (#18025) Update docker/build-push-action action to v6.16.0 (#18030) Update docker/login-action action to v3.4.0 (#18031) Update taiki-e/install-action digest to 83254c5 (#18022) Update cargo-bins/cargo-binstall action to v1.12.4 (#18023) Update Rust crate ctrlc to v3.4.7 (#18027) Update Rust crate clap to v4.5.38 (#18026) Update Rust crate jiff to v0.2.13 (#18029) Update Rust crate getrandom to v0.3.3 (#18028) Update dependency ruff to v0.11.9 (#18024) [`pylint`] add fix safety section (`PLW1514`) (#17932) python_stdlib: update for 3.14 (#18014) [`ruff`] add fix safety section (`RUF033`) (#17760) [`pylint`] add fix safety section (`PLC0414`) (#17802)
3 participants
Summary
The android ndk no longer ships with gcc by default, but jemalloc requires it.
There are some tricks that allow building jemalloc without gcc but this feels unnecessarily complicated.
For now, let's disable jemalloc.
Fixes #18016
Related #17527
Test Plan
I don't have an android device.