[ty] Remove generic types from the daily property test run (for now)#18004
Merged
AlexWaygood merged 1 commit intomainfrom May 11, 2025
Merged
[ty] Remove generic types from the daily property test run (for now)#18004AlexWaygood merged 1 commit intomainfrom
AlexWaygood merged 1 commit intomainfrom
Conversation
AlexWaygood
added
internal
Contributor
|
Member
Author
|
Merging without review because otherwise the property tests will fail again in a few hours. Happy to address any post-merge comments in a followup! |
AlexWaygood
force-pushed
the
alex/fix-property-test
branch
from
edcf9b7 to
045ee60
Compare
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#305.
As of #17832, we understand several classes as generic that we did not previously, including
listandtuple. Instance-types for these classes don't yet pass our property tests, in part because of things such as we don't yet understand thatlist[Any]is not a fully static type. For now, let's make sure that we don't test these types in the daily property test run. We can add them back later when our generics implementation is further along.Test Plan
QUICKCHECK_TESTS=100000 cargo test --release -p ty_python_semantic -- --ignored types::property_tests::stable