Skip S608 for expressionless f-strings#17999
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom May 10, 2025
Merged
Conversation
they are not vulnerable to SQL injections and F541 catches expressionless f-strings with an autofix.
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)
apache/superset (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
+ tests/integration_tests/sqllab_tests.py:191:58: RUF100 [*] Unused `noqa` directive (unused: `S608`)
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 1 | 1 | 0 | 0 | 0 |
Contributor
Author
|
Ecosystem change is this one: names_count = engine.execute(
f"SELECT COUNT(*) FROM birth_names" # noqa: F541, S608
).first()It's the intended effect of not raising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #17967
Summary
Skip
S608for expressionless f-strings.Expressionless f-strings are not vulnerable to SQL injections and F541 catches expressionless f-strings with an autofix.
This is achieved with guarding on the
S608f-string match with an occurrence check for expressions within it; analogous to the implementation of F451.Test Plan
Added a test fixture and updated snapshot.