[pyupgrade] Add resource.error as deprecated alias of OSError (UP024)

[DimitriPapadopoulos]

Summary

Partially addresses #17935.

resource.error is a deprecated alias of OSError.

Changed in version 3.3: Following PEP 3151, this class was made an alias of OSError.

Add it to the list of OSError aliases found by os-error-alias (UP024).

Test Plan

Sorry, I usually don't program in Rust. Could you at least point me to the test I would need to modify?

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[ntBre]

Nice, this makes sense to me! For a test, you'll want to add a new UP024 test fixture like this:

ruff/crates/ruff_linter/resources/test/fixtures/pyupgrade/UP024_3.py

Lines 1 to 8 in ec2fdad

	class SocketError(Exception):
	pass
	try:
	raise SocketError()
	except SocketError:
	pass

It looks like UP024_5.py is the next available name (I linked to 3 since it's a bit more minimal of an example than 4).

And then you can add a new test_case here:

ruff/crates/ruff_linter/src/rules/pyupgrade/mod.rs

Lines 48 to 53 in ec2fdad

	#[test_case(Rule::OSErrorAlias, Path::new("UP024_0.py"))]
	#[test_case(Rule::OSErrorAlias, Path::new("UP024_1.py"))]
	#[test_case(Rule::OSErrorAlias, Path::new("UP024_2.py"))]
	#[test_case(Rule::OSErrorAlias, Path::new("UP024_3.py"))]
	#[test_case(Rule::OSErrorAlias, Path::new("UP024_4.py"))]
	#[test_case(Rule::OpenAlias, Path::new("UP020.py"))]

That should be all you need to generate new snapshots, which you can update with cargo-insta. The prerequisites section in the CONTRIBUTING.md file has some links for setting that up, if you need it. I'm happy to help if you run into any issues! I think this is good to go once we have a simple test case :)

[DimitriPapadopoulos]

I chose to modify the existing test instead:

ruff/crates/ruff_linter/resources/test/fixtures/pyupgrade/UP024_2.py

Lines 8 to 16 in ec2fdad

	# Testing the modules
	import socket, mmap, select
	raise socket.error
	raise mmap.error
	raise select.error
	raise socket.error()
	raise mmap.error(1)
	raise select.error(1, 2)

Unfortunately, the whole toolchain eats too much disk space, I cannot run tests on my computer. I'll try on a machine with more disk space next week.

[ntBre]

Thanks for adding the tests. Let me know if you want me to update the snapshots for you.

[DimitriPapadopoulos]

Snapshots updated.

[ntBre]

Thanks!