[ty] Specialize bound methods and nominal instances#17865
Merged
Conversation
AlexWaygood
reviewed
May 5, 2025
Comment on lines
+4971
to
+4973
| Type::NominalInstance(instance) => Type::NominalInstance( | ||
| instance.apply_specialization(db, specialization), | ||
| ), |
Member
There was a problem hiding this comment.
we probably need to do the same for the Type::ProtocolInstance variant, since protocols can also be generic. But I can do that as part of #17832, if you like, since that's the "hook up the generics infrastructure with the protocols infrastructure" PR 😄
Member
Contributor
|
Member
|
it's a big primer diff and I can't claim to have checked every one in detail. But I spot-checked a few and it's definitely getting rid of real false positives. Some projects have a net increase of diagnostics, but the vast majority of projects are seeing fewer diagnostics (sometimes hundreds fewer) as a result of this change. |
dcreager
changed the title
dcreager
changed the title
Member
Author
|
Most of the new |
carljm
approved these changes
May 5, 2025
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 6, 2025
Fixes astral-sh#17832 (comment). We had a comment that we did not need to apply specializations to generic aliases, or to the bound `self` of a bound method, because they were already specialized. But they might be specialized with a type variable, which _does_ need to be specialized, in the case of a "multi-step" specialization, such as: ```py class LinkedList[T]: ... class C[U]: def method(self) -> LinkedList[U]: return LinkedList[U]() ``` --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17832 (comment). We had a comment that we did not need to apply specializations to generic aliases, or to the bound
selfof a bound method, because they were already specialized. But they might be specialized with a type variable, which does need to be specialized, in the case of a "multi-step" specialization, such as: