Skip to content

[ruff] add fix safety section (RUF033) #17760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylwil3 merged 3 commits into from
May 11, 2025
Merged

[ruff] add fix safety section (RUF033) #17760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75da35e
add fix safety section
VascoSch92 May 1, 2025
95f26ae
add fix safety section
VascoSch92 May 4, 2025
a6ae8f8
add fix safety section
VascoSch92 May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/ruff_linter/src/rules/ruff/rules/post_init_default.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ use super::helpers::{dataclass_kind, DataclassKind};
/// foo = Foo() # Prints '1 2'.
/// ```
///
/// ## Fix safety
///
/// This fix is always marked as unsafe because, although switching to `InitVar` is usually correct,
/// it is incorrect when the parameter is not intended to be part of the public API or when the value
/// is meant to be shared across all instances.
///
/// ## References
/// - [Python documentation: Post-init processing](https://docs.python.org/3/library/dataclasses.html#post-init-processing)
/// - [Python documentation: Init-only variables](https://docs.python.org/3/library/dataclasses.html#init-only-variables)
Expand Down
Loading