[semantic-syntax-tests] for for InvalidStarExpression, DuplicateMatchKey, and DuplicateMatchClassAttribute#17754
Merged
ntBre merged 3 commits intoastral-sh:mainfrom May 5, 2025
Merged
Conversation
maxmynter
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Contributor
|
maxmynter
changed the title
maxmynter
changed the title
InvalidStarExpression, DuplicateMatchKey, and DuplicateMatchClassAttribute
Contributor
|
for `InvalidStarExpression`, `DuplicateMatchKey`, and `DuplicateMatchClassAttribue`
ntBre
force-pushed
the
semantic-coverage-v2
branch
from
c54410d to
ea62fc9
Compare
Contributor
|
I rebased to pick up the |
Contributor
|
Ah, I forgot we changed the error message in #17772 too. I'll push one more update. |
AlexWaygood
pushed a commit
that referenced
this pull request
May 5, 2025
…tchKey`, and `DuplicateMatchClassAttribute` (#17754) Re: #17526 ## Summary Add integration tests for Python Semantic Syntax for `InvalidStarExpression`, `DuplicateMatchKey`, and `DuplicateMatchClassAttribute`. ## Note - Red knot integration tests for `DuplicateMatchKey` exist already in line 89-101. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan This is a test. <!-- How was it tested? -->
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 6, 2025
…tchKey`, and `DuplicateMatchClassAttribute` (astral-sh#17754) Re: astral-sh#17526 ## Summary Add integration tests for Python Semantic Syntax for `InvalidStarExpression`, `DuplicateMatchKey`, and `DuplicateMatchClassAttribute`. ## Note - Red knot integration tests for `DuplicateMatchKey` exist already in line 89-101. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan This is a test. <!-- How was it tested? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #17526
Summary
Add integration tests for Python Semantic Syntax for
InvalidStarExpression,DuplicateMatchKey, andDuplicateMatchClassAttribute.Note
DuplicateMatchKeyexist already in line 89-101.Test Plan
This is a test.