Skip to content

[ruff] add fix safety section (RUF028) #17722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 2 commits into from
Apr 30, 2025
Merged

[ruff] add fix safety section (RUF028) #17722

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf1872
add fix safety section
VascoSch92 Apr 29, 2025
7fadaa4
Update invalid_formatter_suppression_comment.rs
VascoSch92 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ use super::suppression_comment_visitor::{
/// # fmt: on
/// # yapf: enable
/// ```
///
/// ## Fix safety
///
/// This fix is always marked as unsafe because it deletes the invalid suppression comment,
/// rather than trying to move it to a valid position, which the user more likely intended.
///
#[derive(ViolationMetadata)]
pub(crate) struct InvalidFormatterSuppressionComment {
reason: IgnoredReason,
Expand Down
Loading