Skip to content

[ruff] add fix safety section (RUF005) #17484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylwil3 merged 4 commits into from
Apr 26, 2025
Merged

[ruff] add fix safety section (RUF005) #17484

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b8b4f4
add fix safety section
VascoSch92 Apr 19, 2025
c21051b
suggestion crates/ruff_linter/src/rules/ruff/rules/collection_literal…
VascoSch92 Apr 26, 2025
00ffb8f
Suggestion crates/ruff_linter/src/rules/ruff/rules/collection_literal…
VascoSch92 Apr 26, 2025
6601026
Suggestion crates/ruff_linter/src/rules/ruff/rules/collection_literal…
VascoSch92 Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/ruff_linter/src/rules/ruff/rules/collection_literal_concatenation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ use crate::fix::snippet::SourceCodeSnippet;
/// bar = [1, *foo, 5, 6]
/// ```
///
/// ## Fix safety
///
/// The fix is always marked as unsafe because the `+` operator uses the `__add__` magic method and
/// `*`-unpacking uses the `__iter__` magic method. Both of these could have custom
/// implementations, causing the fix to change program behaviour.
///
/// ## References
/// - [PEP 448 – Additional Unpacking Generalizations](https://peps.python.org/pep-0448/)
/// - [Python documentation: Sequence Types — `list`, `tuple`, `range`](https://docs.python.org/3/library/stdtypes.html#sequence-types-list-tuple-range)
Expand Down
Loading