[red-knot] allow assignment expression in call compare narrowing #17461
+32
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewMckee4
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
MatthewMckee4
commented
Apr 18, 2025
Comment on lines
+241
to
+251
| fn expr_name(expr: &ast::Expr) -> Option<&ast::name::Name> { | ||
| match expr { | ||
| ast::Expr::Named(ast::ExprNamed { target, .. }) => match target.as_ref() { | ||
| ast::Expr::Name(ast::ExprName { id, .. }) => Some(id), | ||
| _ => None, | ||
| }, | ||
| ast::Expr::Name(ast::ExprName { id, .. }) => Some(id), | ||
| _ => None, | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Im not sure the best place to put a function like this
Contributor
There was a problem hiding this comment.
I think this is a fine spot for now!
Contributor
|
carljm
approved these changes
Apr 18, 2025
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Great catch, and nice implementation!!
Comment on lines
+241
to
+251
| fn expr_name(expr: &ast::Expr) -> Option<&ast::name::Name> { | ||
| match expr { | ||
| ast::Expr::Named(ast::ExprNamed { target, .. }) => match target.as_ref() { | ||
| ast::Expr::Name(ast::ExprName { id, .. }) => Some(id), | ||
| _ => None, | ||
| }, | ||
| ast::Expr::Name(ast::ExprName { id, .. }) => Some(id), | ||
| _ => None, | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think this is a fine spot for now!
| }) => { | ||
| if let ast::Expr::Name(ast::ExprName { id, .. }) = target.as_ref() { | ||
| ast::Expr::Name(_) | ast::Expr::Named(_) => { | ||
| if let Some(id) = expr_name(left) { |
dcreager
added a commit
that referenced
this pull request
Apr 18, 2025
* main: (123 commits) [red-knot] Handle explicit class specialization in type expressions (#17434) [red-knot] allow assignment expression in call compare narrowing (#17461) [red-knot] fix building unions with literals and AlwaysTruthy/AlwaysFalsy (#17451) [red-knot] Type narrowing for assertions (take 2) (#17345) [red-knot] class bases are not affected by __future__.annotations (#17456) [red-knot] Add support for overloaded functions (#17366) [`pyupgrade`] Add fix safety section to docs (`UP036`) (#17444) [red-knot] more type-narrowing in match statements (#17302) [red-knot] Add some narrowing for assignment expressions (#17448) [red-knot] Understand `typing.Protocol` and `typing_extensions.Protocol` as equivalent (#17446) Server: Use `min` instead of `max` to limit the number of threads (#17421) [red-knot] Detect version-related syntax errors (#16379) [`pyflakes`] Add fix safety section (`F841`) (#17410) [red-knot] Add `KnownFunction` variants for `is_protocol`, `get_protocol_members` and `runtime_checkable` (#17450) Bump 0.11.6 (#17449) Auto generate `visit_source_order` (#17180) [red-knot] Initial tests for protocols (#17436) [red-knot] Dataclasses: synthesize `__init__` with proper signature (#17428) [red-knot] Dataclasses: support `order=True` (#17406) [red-knot] Super-basic generic inference at call sites (#17301) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was some narrowing constraints not covered from the previous PR
Also, refactored a bit
Test Plan
Update type_api.md